Fix Provided consistent behavior of text color in tabbed page in all platforms. #24782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-18775
branch
from
39b1f89
to
3ea354d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Sep 25, 2024
|
I checked the device logs and it looks like iOS controls is locking up from HybridWebView tests unrelated to this PR
|
samhouts
added
the
fixed-in-net9.0-nightly
|
@PureWeen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The unSelectedBarTextColor is passed as null by default. This causes the tint color of the UITabbar to be applied. As a result, unSelectedBarTextColor on the iOS and Mac platforms is a different color.
Description of Change
We can pass the BarTextColor property to the unSelectedBarTextColor instead of null.
Validated the behaviour in the following platforms
Output Screenshot