Skip to content

Reduce allocations in ProjectItemInstance.CommonConstructor by settin… #12978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nareshjo wants to merge 9 commits into
base: main
Choose a base branch
from
+10 −1
Open

Reduce allocations in ProjectItemInstance.CommonConstructor by settin… #12978

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b9b3cf7
Reduce allocations in ProjectItemInstance.CommonConstructor by settin…
Jan 5, 2026
e1c4b03
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 7, 2026
855fd38
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 7, 2026
5a3feb9
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 9, 2026
b62c962
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 9, 2026
7f25dce
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 13, 2026
da2fd77
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 15, 2026
479f74d
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 15, 2026
321d88e
Merge branch 'main' into dev/nareshjo/commonconstructor-alloc
nareshjo Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Build/Instance/ProjectItemInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,16 @@ private void CommonConstructor(
if (itemDefinitions == null || !useItemDefinitionsWithoutModification)
{
// TaskItems don't have an item type. So for their benefit, we have to lookup and add the regular item definition.
inheritedItemDefinitions = (itemDefinitions == null) ? null : new List<ProjectItemDefinitionInstance>(itemDefinitions);
if (itemDefinitions == null)
{
inheritedItemDefinitions = null;
}
else
{
List<ProjectItemDefinitionInstance> list = new List<ProjectItemDefinitionInstance>(itemDefinitions.Count + 1); // account for possible addition below to avoid resizing
Copy link
Member

@AR-May AR-May Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to have this list variable.

Copy link
Contributor Author

@nareshjo nareshjo Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AI agent used a list variable to be able to call AddRange(), which is not available on inheritedItemDefinitions which is IList.
I agree it can be done without the variable by casting since we just created it as a List. Were you suggesting something like this?

inheritedItemDefinitions = (itemDefinitions == null) ? null : new List<ProjectItemDefinitionInstance>(itemDefinitions.Count + 1);
((List<ProjectItemDefinitionInstance>)inheritedItemDefinitions)?.AddRange(itemDefinitions);

list.AddRange(itemDefinitions);
inheritedItemDefinitions = list;
}

ProjectItemDefinitionInstance itemDefinition;
if (projectToUse.ItemDefinitions.TryGetValue(itemTypeToUse, out itemDefinition))
Expand Down