Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test project#13481
Open
Youssef1313 wants to merge 3 commits intomainfrom
Open
Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test project#13481Youssef1313 wants to merge 3 commits intomainfrom
Youssef1313 wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure ThreadSafeTaskAnalyzer.Tests is treated as a unit test project by Arcade/build tooling, while still allowing the project to opt out of repo-injected shared unit test sources.
Changes:
- Replaces the project-level opt-out (
IsUnitTestProject=false) with a new opt-out switch (DisableTestSharedFiles) inThreadSafeTaskAnalyzer.Tests.csproj. - Updates
src/Directory.Build.targetsso shared unit test items are only injected whenDisableTestSharedFilesis not enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ThreadSafeTaskAnalyzer.Tests/ThreadSafeTaskAnalyzer.Tests.csproj |
Switches from disabling unit-test classification to using a new property to suppress shared test file injection. |
src/Directory.Build.targets |
Adds DisableTestSharedFiles to the condition guarding injection of shared unit test items. |
Youssef1313
force-pushed
the
dev/ygerges/threadsafe-task-tests
branch
from
c84438c to
6158861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test project is likely not running today via Arcade:
https://github.com/dotnet/arcade/blob/89c91f8f98b2a98ecf90461afefa9aa7d3cb5281/src/Microsoft.DotNet.Arcade.Sdk/tools/Tests.targets#L35