-
Notifications
You must be signed in to change notification settings - Fork 286
.NET projects cleanup + set minimum dependency to net472 for microbenchmarks #4982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many conditions can be simplified, like in #4977
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, if we want to include the extra cleanup in the MicroBenchmarks.csproj file in this PR, that works for me, or we can do it in another PR.
src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj
Outdated
Show resolved
Hide resolved
src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
This PR does a few things:
NU1510
#4975.