Small fixes #9597
Merged
Small fixes #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably not of any consequence, but the paths were invalid.
We were referencing `MessagePack` twice in `Microsoft.VisualStudio.ProjectSystem.Managed`.
zewditu
reviewed
Nov 21, 2024
| @@ -50,8 +50,6 @@ | |||
| <ItemGroup> | |||
| <!-- Needed to break assembly conflict on StreamJsonRpc between microsoft.visualstudio.projectsystem.query and microsoft.visualstudio.languageservices --> | |||
| <PackageReference Include="Microsoft.VisualStudio.RpcContracts" /> | |||
| <!-- Pin MessagePack to a patched version with security vulnerable fix --> | |||
| <PackageReference Include="MessagePack" /> | |||
There was a problem hiding this comment.
Does this have dependency somewhere? where is this in another place?
There was a problem hiding this comment.
Yes, it was added recently in the host agnostic file.
zewditu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some build warnings and other IDE warnings seen while reading through code today.
Microsoft Reviewers: Open in CodeFlow