Ignore case when parsing enum values in settings in VS Code #12667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
approved these changes
Jan 12, 2026
.../src/Microsoft.VisualStudioCode.RazorExtension/Services/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.VisualStudioCode.RazorExtension/Services/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.VisualStudioCode.RazorExtension/Services/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.VisualStudioCode.RazorExtension/Services/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.VisualStudioCode.RazorExtension/Services/CohostConfigurationChangedService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Jan 12, 2026
...test/Microsoft.VisualStudioCode.RazorExtension.Test/CohostConfigurationChangedServiceTest.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Jan 12, 2026
| } | ||
|
|
||
| if (Enum.TryParse<T>(jsonNode.GetValue<string>(), out var value)) | ||
| if (Enum.TryParse<T>(jsonNode.GetValue<string>(), ignoreCase: true, out var value)) |
Contributor
Member
Author
There was a problem hiding this comment.
I can't remember if it was paranoia or a user report, or maybe even me stuffing up my own settings file, but users directly modify the settings json in VS Code so the difference between "value": true and "value": "true" doesn't seem like it should be their problem, IMO.
ToddGrun
approved these changes
Jan 12, 2026
Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
davidwengier
commented
Jan 12, 2026
...test/Microsoft.VisualStudioCode.RazorExtension.Test/CohostConfigurationChangedServiceTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when testing our latest VS Code insertion. I missed ignoring the case when parsing the enum, when adding this setting, and also missed that the tests we had were for the old language server so they didn't fail because I got that code right 🤦♂️