Include project diagnostic suppressors in host analyzer execution #75684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
sharwell
commented
Nov 1, 2024
| telemetry = telemetry.AddRange(hostAnalysisResult.AnalyzerTelemetryInfo); | ||
| // Use SetItems instead of AddRange so exceptions will not occur if diagnostic suppressors are | ||
| // counted in both project and host analysis results. | ||
| telemetry = telemetry.SetItems(hostAnalysisResult.AnalyzerTelemetryInfo); |
There was a problem hiding this comment.
📝 This could negatively impact telemetry accuracy by only including timing information for the host execution of suppressors. It's not clear how important it is to merge the data instead of overwrite it.
| @@ -146,6 +146,8 @@ static string GetLanguageSpecificId(string? language, string noLanguageId, strin | |||
| // Create driver that holds onto compilation and associated analyzers | |||
| var filteredProjectAnalyzers = projectAnalyzers.WhereAsArray(static a => !a.IsWorkspaceDiagnosticAnalyzer()); | |||
| var filteredHostAnalyzers = hostAnalyzers.WhereAsArray(static a => !a.IsWorkspaceDiagnosticAnalyzer()); | |||
| var filteredProjectSuppressors = filteredProjectAnalyzers.WhereAsArray(static a => a is DiagnosticSuppressor); | |||
| filteredHostAnalyzers = filteredHostAnalyzers.AddRange(filteredProjectSuppressors); | |||
There was a problem hiding this comment.
📝 This path is hit by the test that was failing, and revealed a case of AddRange causing a problem. It's not clear how well this or other paths are exercised, so I'm certainly concerned with bugs slipping through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75399