Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi][mono] Fix conflicting naming for wasm import/export #103881

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[wasi][mono] Fix conflicting naming for wasm import/export #103881

merged 2 commits into from
Jun 26, 2024

Conversation

mkhamoyan
Copy link
Contributor

Fixes #102844

@mkhamoyan mkhamoyan requested review from lewing and kg June 24, 2024 07:01
This was referenced Jun 24, 2024
Open
Open
kg
kg approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, assuming everything works. Would like to see it simplified to use the same format for every case, assuming it won't break anything to do so.

@mkhamoyan mkhamoyan marked this pull request as ready for review June 25, 2024 08:35
This was referenced Jun 25, 2024
Closed
Closed
Open
Closed
Closed
Closed
@mkhamoyan mkhamoyan merged commit ce02b53 into dotnet:main Jun 26, 2024
34 of 36 checks passed
@mkhamoyan mkhamoyan mentioned this pull request Jun 26, 2024
Draft
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@mkhamoyan mkhamoyan

Labels
area-Interop-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm][mono] conflicting naming for wasm import/export
2 participants
@mkhamoyan @kg