Run ILC after ComputeResolvedFilesToPublishList

[sbomer]

Fixes #108909

Needs more testing, but seems to work with a small repro so far.

[MichalStrehovsky]

Did you consider using the scheme that ILLink/R2R/SingleFile use right now?

It feels like it would make the sequencing most "standard". We'd probably need to wait for the new SDK to flow to this repo but we just did an upgrade and we could do another one.

[sbomer]

This moves us in that direction - now this target will be sequenced appropriately - and we can change from AfterTargets to DependsOnTargets in a later change. I'm looking at the native aot targets all-up to see if there's other logic that needs cleanup, but wanted to start with this piece.

[MichalStrehovsky]

Nice!

[MichalStrehovsky]

(The CI failures look related)

[ivanpovazan]

/azp run runtime-ioslike

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[ivanpovazan]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[steveisok]

@ivanpovazan is there going to be any work required in the iOS SDK as a result of this change?

[ivanpovazan]

@ivanpovazan is there going to be any work required in the iOS SDK as a result of this change?

No, because we opt-out from NativeAOT Publish targets and handle them differently:
https://github.com/xamarin/xamarin-macios/blob/8d57fe69ca1d9d63c8da2c9b5672eda4ea69ab4d/dotnet/targets/Xamarin.Shared.Sdk.props#L189

[ivanpovazan]

@sbomer ios/tvos test failures seem related, let me know if I can help with those.

[ivanpovazan]

Remove this change, see my comment below.

[ivanpovazan]

I don't think we should put this target here.

LibraryBuilder.props/targets are intended for Mono's library mode support, and none of the MSBuild targets from this file should be needed for NativeAOT (I admit there are other hacks which are advocating against this).

If I understand correctly, you added this target so that NativeAOT library mode has the previous CopyNativeBinary behavior, correct?

If that is the case, then I would:

1. Move this target into AppleBuild.targets
2. Remove it from AppleBuildDependsOn (see my comment above)
3. Add it manually as a last dependency at:

   runtime/src/mono/msbuild/apple/build/AppleBuild.targets

   Line 276 in 572533b

   DependsOnTargets="SetupProperties;ComputeIlcCompileInputs;IlcCompile;$(_IlcLibraryBuildDependsOn)" />

4. Put a condition on it: Condition="'$(_IsLibraryMode)' == 'true' and '$(UseNativeAOTRuntime)' == 'true'"

This way it does not affect: Mono app or lib builds, and it does not affect NativeAOT app builds. We will eventually clean all of this up in the internal props/targets as we now have experimental CoreCLR support for Apple as well.