[release/10.0] Suppress warnings in JSON source generated code #120191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
stephentoub
added
NO-MERGE
|
Approved offline for servicing. I've marked it as no-merge temporarily though as we discuss a few things. |
jeffhandley
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120181 to release/10.0
/cc @stephentoub
Customer Impact
Any warnings-as-errors or errors in code emitted by the JSON source generator breaks the build. This in particular impacts the use of
[Experimental]in types that show up anywhere in the type graph of types used with the JSON source generator, because the source generator emits use of those[Experimental]members, which then results in error diagnostics blocking compilation. This in turn makes it really hard for developers (including the .NET team) to experiment in stable assemblies.Regression
Testing
Manually used the new build in a project and validated that [Experimental] use goes from producing errors to building successfully.
Risk
Low. The change is simply suppressing more diagnostics in the source generated code, replacing:
which suppresses all nullability related warnings and several obsoletion-related warnings, with:
which suppresses all diagnostics.
This is only done in release builds of the source generator, so that in debug builds we still get the same information about possible issues to be addressed.