Fix documentation to clarify culture name usage for case-insensitive comparisons in GeneratedRegexAttribute #121073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comparisons in GeneratedRegexAttribute
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
stephentoub
approved these changes
Oct 26, 2025
|
Thanks |
There was a problem hiding this comment.
Pull Request Overview
This PR corrects documentation errors in the GeneratedRegexAttribute class where the cultureName parameter's purpose was incorrectly described. The documentation previously stated that culture names are used for "case sensitive comparisons" when they are actually used for "case-insensitive comparisons" in regular expression matching.
Key changes:
- Corrected three instances of misleading documentation regarding the purpose of the
cultureNameparameter - Changed "case sensitive" to "case-insensitive" to accurately reflect how culture names affect regex matching behavior
|
Port to dotnet-api-docs: dotnet/dotnet-api-docs#11975 |
jkotas
added a commit
to dotnet/dotnet-api-docs
that referenced
this pull request
Oct 26, 2025
Ports documentation fix from dotnet/runtime#121073. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation appears to be incorrect.