Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a source generator for invoking methods on unmanaged vtables #68276

Merged
merged 40 commits into from
Oct 11, 2022
Merged

Introduce a source generator for invoking methods on unmanaged vtables #68276

merged 40 commits into from
Oct 11, 2022

Commits on May 12, 2022

  1. WIP for generating stubs for manual vtable entrypoints.

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    de8d813 View commit details
    Browse the repository at this point in the history

  2. Fix up some names and actually parse the right attribute.

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    4e23511 View commit details
    Browse the repository at this point in the history

  3. Update ComInterfaceGenerator to not pass syntax around

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6b6020a View commit details
    Browse the repository at this point in the history

  4. Move TestUtils to a shared location and get our first test unit test … 

    …with the vtable index generator to pass.
    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    ac354c6 View commit details
    Browse the repository at this point in the history

  5. Add some tests around calling convention handling.

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    2af787c View commit details
    Browse the repository at this point in the history

  6. Add tests for the emitted native interface type shape

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6d7327b View commit details
    Browse the repository at this point in the history

  7. Add some basic marshalling tests to give some validation that we set … 

    …up the marshalling generator correctly (E2E-style validation)
    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b9f3597 View commit details
    Browse the repository at this point in the history

  8. Add design doc, update API name, remove scratch pad

    @jkoritzinsky
    jkoritzinsky committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7caa3c7 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Fix build and run

    @jkoritzinsky
    jkoritzinsky committed May 13, 2022
    Configuration menu
    Copy the full SHA
    6e7e119 View commit details
    Browse the repository at this point in the history

  2. Fix markdownlint failures

    @jkoritzinsky
    jkoritzinsky committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f862f15 View commit details
    Browse the repository at this point in the history

  3. infra fixes for ComInterfaceGenerator test runs

    @jkoritzinsky
    jkoritzinsky committed May 13, 2022
    Configuration menu
    Copy the full SHA
    09dc2c4 View commit details
    Browse the repository at this point in the history

  4. Add more tests

    @jkoritzinsky
    jkoritzinsky committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a83b092 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Exclude ComInterfaceGenerator on mobile platforms

    @jkoritzinsky
    jkoritzinsky committed May 16, 2022
    Configuration menu
    Copy the full SHA
    faa674e View commit details
    Browse the repository at this point in the history

  2. Add basic runtime tests

    @jkoritzinsky
    jkoritzinsky committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a55e337 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Remove extraneous diagnostic

    @jkoritzinsky
    jkoritzinsky committed May 26, 2022
    Configuration menu
    Copy the full SHA
    7e92bd4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed May 26, 2022
    Configuration menu
    Copy the full SHA
    f54bd51 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d95cdac View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    2e2809a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Fix build break

    @jkoritzinsky
    jkoritzinsky committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8fef109 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    7736687 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Get the generator up to date with our newer designs and increase the … 

    …test battery by sharing some code snippets with LibraryImportGenerator.
    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    794c4cf View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    5627e53 View commit details
    Browse the repository at this point in the history

  2. Use static abstracts instead of partial + containing class to define … 

    …a solid contract to simplify authoring our custom type marshalling tests
    @jkoritzinsky
    jkoritzinsky committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a958552 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Use MarshalDirection type in generators and update design doc

    @jkoritzinsky
    jkoritzinsky committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    7182f4b View commit details
    Browse the repository at this point in the history

  2. Use static-abstracts + DIMs to remove the extra shape validation.

    @jkoritzinsky
    jkoritzinsky committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9ca69dd View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Fix JS generator test build

    @jkoritzinsky
    jkoritzinsky committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    5746f8b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Fix exclusions

    @jkoritzinsky
    jkoritzinsky committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    032ebff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8ac684c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    fbe5edf View commit details
    Browse the repository at this point in the history

  2. Fix exclusions of runtime tests

    @jkoritzinsky
    jkoritzinsky committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d964d0c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Disable runtime tests on Mono because Mono doesn't implement an API t… 

    …hat the tests all use
    @jkoritzinsky
    jkoritzinsky committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    bf8485a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Fix test disable to work in the normal runtime pipeline, albeit not p… 

    …articularly efficiently.
    @jkoritzinsky
    jkoritzinsky committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7fc5e52 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Merge branch 'main' into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    2868df2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    19a5b01 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Directly pass along target framework kind and version instead of Stub… 

    …Environment to avoid rooting the compilation. Update all generators to follow suit and add a test in LibraryImportGenerator to validate that we don't keep the compilation alive.

Also fix the build failure in ComInterfaceGenerator
    @jkoritzinsky
    jkoritzinsky committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    3008cd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Use a wrapper struct to make using elementwise equality for immutable… 

    … arrays easier.
    @jkoritzinsky
    jkoritzinsky committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1d8bd6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    229f45a View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Merge branch 'main' into vtable-stubs

    @jkoritzinsky
    jkoritzinsky committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    4f89920 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @jkoritzinsky
    jkoritzinsky committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d403851 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Update the generator entry-point and the project file based on change… 

    …s that have occured in our policy since this branch was started
    @jkoritzinsky
    jkoritzinsky committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    1e890d4 View commit details
    Browse the repository at this point in the history