Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache the Compilation object in steps in the interop source generators #76474

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Don't cache the Compilation object in steps in the interop source generators #76474

merged 4 commits into from
Oct 7, 2022

Commits on Sep 30, 2022

  1. Directly pass along target framework kind and version instead of Stub… 

    …Environment to avoid rooting the compilation. Update all generators to follow suit and add a test in LibraryImportGenerator to validate that we don't keep the compilation alive.
    @jkoritzinsky
    jkoritzinsky committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    eea9df2 View commit details
    Browse the repository at this point in the history

  2. Use a wrapper struct to make using elementwise equality for immutable… 

    … arrays easier.
    @jkoritzinsky
    jkoritzinsky committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    d01947d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Remove accidentally included file

    @jkoritzinsky
    jkoritzinsky committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    ea2f98c View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    2479ec9 View commit details
    Browse the repository at this point in the history