Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust CommonTemplatesTests to net8 changes in templates #29197

Closed
JanKrivanek opened this issue Nov 23, 2022 · 3 comments
Closed

Adjust CommonTemplatesTests to net8 changes in templates #29197

JanKrivanek opened this issue Nov 23, 2022 · 3 comments
Assignees
@JanKrivanek
Labels
Area-Common templates Covers templates in the repo (classlib, console, common item templates) triaged the item was triaged and placed to the backlog

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Nov 23, 2022 •
edited by vlada-shubina
Loading

#27486
#28707

CommonTemplatesTests will need to accomodate changes - specifically:

  • net8.0 TFM needs to be added to test matrix
  • add tests for new item templates synonyms: .gitignore, global.json, nuget.config, .editorconfig (ideally while sharing snapshots with existing shortnames to verify identity of output)

Related work: adding C# 12 to test matrix: dotnet/templating#6566
@JanKrivanek JanKrivanek self-assigned this Nov 23, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Nov 23, 2022
@JanKrivanek JanKrivanek added Area-Common templates Covers templates in the repo (classlib, console, common item templates) untriaged Request triage from a team member and removed Area-DotNet Test untriaged Request triage from a team member labels Nov 23, 2022
@JanKrivanek JanKrivanek mentioned this issue Nov 24, 2022
Merged
@JanKrivanek
Copy link
Member Author

Adressed by 3ccb7ba

@JanKrivanek
Copy link
Member Author

.net6.0 X C# >= 11.0 and default cases are removed from the new test matrix temporarily (dotnet/templating#5668)

@vlada-shubina vlada-shubina added triaged the item was triaged and placed to the backlog and removed untriaged Request triage from a team member labels Nov 28, 2022
@vlada-shubina
Copy link
Member

Already addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanKrivanek JanKrivanek

Labels
Area-Common templates Covers templates in the repo (classlib, console, common item templates) triaged the item was triaged and placed to the backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanKrivanek @vlada-shubina