Template verifier adoption in CommonTemplateTests #28707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
JanKrivanek
added
Area-dotnet new
26 tasks
JanKrivanek
changed the title
JanKrivanek
force-pushed
the
template-verifier
branch
from
33e7101
to
d360677
Compare
2 tasks
|
Restore action executed through the TemplateVerifier fails on Ubuntu and Darwin with
Caused by not using the dotnet.exe from artifacts folder. To support custom dotnet location a VerificationEngine rework is needed that'll be done after dotnet/templating#5482 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JanKrivanek
force-pushed
the
template-verifier
branch
from
21be6c1
to
b307d23
Compare
JanKrivanek
force-pushed
the
template-verifier
branch
from
b307d23
to
7be7c25
Compare
vlada-shubina
requested changes
Nov 22, 2022
vlada-shubina
approved these changes
Nov 23, 2022
JanKrivanek
force-pushed
the
template-verifier
branch
from
c58babd
to
3ccb7ba
Compare
vlada-shubina
approved these changes
Nov 24, 2022
| [InlineData("global.json file", "globaljson", null)] | ||
| [InlineData("global.json file", "globaljson", new[] { "--sdk-version", "5.0.200" })] | ||
| [InlineData("global.json file", "globaljson", new[] { "--sdk-version", "5.0.200", "--roll-forward", "major" })] | ||
| [InlineData("global.json file", "global.json", null)] | ||
| [InlineData("global.json file", "global.json", new[] { "--sdk-version", "5.0.200" })] |
There was a problem hiding this comment.
we should remove .NET 5 here (EOL), can be done in another PR
…with features conditions
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
YuliiaKovalova
pushed a commit
to YuliiaKovalova/sdk
that referenced
this pull request
Dec 15, 2022
Template verifier adoption in CommonTemplateTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of dotnet/templating#3868
Coverting the CommonTemplateTests from manually running processes and checking outputs to use the verification tooling
Solution
Verification tooling importent and tests converted and adjusted.
Some repetitive tests (running identical scenarios but testing different parts of outputs) were consolidated