Added support of C#11 to templates #27361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
changed the title
|
Related PRs: |
bekir-ozturk
approved these changes
Aug 23, 2022
jaredpar
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the templates, the generators which determine minimum language version in use were not considering C#11.
Fixed regex to support it.
Customer impact
Without this fix, using C# 11.0 via
--langVersionoption will result in old style template (no top level statements, file scoped namespaces, implicit usings)Testing
Automated
Risk
Very low.
Language version option is only available in CLI and not exposed in Visual Studio.