Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.1xx] Update dependencies from dotnet/templating #36136

Merged
merged 13 commits into from
Oct 20, 2023
Merged

[release/8.0.1xx] Update dependencies from dotnet/templating #36136

merged 13 commits into from
Oct 20, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 16, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/templating

  • Subscription: 49f893b0-29b9-4954-0eaa-08db9e40a4f0
  • Build: 20231019.26
  • Date Produced: October 20, 2023 7:15:54 AM UTC
  • Commit: 901160aaf6aa9b238e6acf6ca9fcbe600b111f35
  • Branch: refs/heads/release/8.0.1xx

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
4a8489f 
…0231015.3

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23515.3
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Oct 16, 2023
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/templating:

@dotnet/templating-engine-maintainers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/templating) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
1699b78 
…0231016.16

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23516.16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
193fcc5 
…0231017.16

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23517.16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
c492ae2 
…0231017.20

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23517.20
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
35ae1e6 
…0231017.24

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23517.24
@marcpopMSFT
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
78491b2 
…0231018.9

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23518.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
aea589e 
…0231018.20

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23518.20
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
e09496a 
…0231018.27

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23518.27
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
572ce2d 
…0231018.37

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23518.37
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
eb77920 
…0231019.1

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23519.1
@v-wuzhai
Copy link
Member

@ViktorHofer @marcpopMSFT looks like the 8.0 branch can't get around implicit xunit/2.5.1.

@ViktorHofer
Copy link
Member

I would question the value of updating to xunit 2.5.1 in dotnet/templating in the corresponding release/8.0.1xx branch. I think it would be best to revert that xunit dependency update in their branch.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
0c8abab 
…0231019.3

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23519.3
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 19, 2023 •
edited
Loading

This change caused the dependency update and should probably be reverted: dotnet/templating#7145. I would recommend disabling dependabot in release branches. Otherwise, the repository plus everyone consuming its dependencies accepts the cost of updating dependencies.

The cost of updating to xunit 2.5.1 was very high in main and I don't see the justification to backport the necessary changes into release/8.0.1xx.

In addition to that, I see that Verify.xunit gets updated via dependabot but xunit via Arcade. That's a mismatch that will cause this exact failure again when Verify.xunit publishes a new version that depends on a newer xunit version. Verify.xunit should probably not be auto-updated alltogether.

cc @dotnet/templating-engine-maintainers

@MiYanni
Copy link
Member

MiYanni commented Oct 19, 2023

@ViktorHofer Reverting that PR here: dotnet/templating#7177

@marcpopMSFT
Copy link
Member

@MiYanni , I'm supportive of dependabot only being on in main given the issues we've had with it.

@MiYanni MiYanni mentioned this pull request Oct 20, 2023
Merged
@MiYanni
Copy link
Member

MiYanni commented Oct 20, 2023

@marcpopMSFT

I'm supportive of dependabot only being on in main given the issues we've had with it.

Updating it to only happen on main here: dotnet/templating#7178

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
0a52641 
…0231019.13

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23519.13
@v-wuzhai
Copy link
Member

v-wuzhai commented Oct 20, 2023 •
edited
Loading

@ViktorHofer @MiYanni It seems that PRs #7121 and #7149 need to be restored also include, can you help to confirm?

@ViktorHofer
Copy link
Member

See my comments here: dotnet/templating#7149 (comment)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
8b62d82 
…0231019.26

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 8.0.100-rtm.23512.5 -> To Version 8.0.100-rtm.23519.26
@v-wuzhai v-wuzhai merged commit 7e33fd4 into release/8.0.1xx Oct 20, 2023
20 checks passed
@v-wuzhai v-wuzhai deleted the darc-release/8.0.1xx-5b6ea5a4-06d1-4a6c-92a0-07b6ab6874b9 branch October 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-wuzhai v-wuzhai v-wuzhai approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcpopMSFT @v-wuzhai @ViktorHofer @MiYanni