Run 'AddImplicitDefineConstants' on 'BeforeCompile' #44695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-NetSDK
untriaged
This was referenced Nov 7, 2024
rainersigwald
approved these changes
Nov 7, 2024
Sergio0694
force-pushed
the
user/sergiopedri/fix-AddImplicitDefineConstants-xaml
branch
from
e894826
to
ae2b63a
Compare
Sergio0694
force-pushed
the
user/sergiopedri/fix-AddImplicitDefineConstants-xaml
branch
from
ae2b63a
to
4cd69e8
Compare
|
@rainersigwald CI is all green (but I don't have permissions), can we merge this? 😄 Also, do you think we could backport this to .NET 9? Should I fill out the usual servicing form? Thank you! |
|
I'd need @rainersigwald to weigh in on how risky moving this is as we typically don't take this sort of change for 9. 9.0.2xx is open but this is borderline. We'd need high confidence of no break to consider for 1xx. |
|
If it helps, 9.0.2xx would also be fine (I assume that'd go out somewhere in January?). My concern was mostly about not being able to get the fix until all the way to November 2025 with .NET 10. So even just 9.0.2xx would be better than that 😅 |
Sergio0694
deleted the
user/sergiopedri/fix-AddImplicitDefineConstants-xaml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43908
This PR changes "AddImplicitDefineConstants" to use "BeforeCompile" as trigger, instead of "CoreCompile".