Switch markdownlint GH action to use super-linter #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| name: Lint Code Base | ||
|
|
||
| on: | ||
| pull_request: null |
There was a problem hiding this comment.
Is this a change in behavior? Previously, linter was supposedly on for PRs with a list of file patterns.
There was a problem hiding this comment.
It is on for PRs with no specific file patterns (e.g. all PRs). The idea is it allows for the easy enablement of other linters supported by the super-linter. e.g. scripting, json, yml, etc.
ellahathaway
approved these changes
Aug 20, 2024
NikolaMilosavljevic
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/dotnet-docker#5316
Switched the MarkDown linter GH action to use the super-linter. This gives us the advantage of enabling other linters via a "flip of a switch". The configuration will be more standardized with the super-linter versus having separate GH actions/linters. The super-linter used the markdownlint tool we are already using so there should be no functional changes.