Merge pull request #8269 from dotnet/merge/release/8.0.3xx-to-release…

…/8.0.4xx [automated] Merge branch 'release/8.0.3xx' => 'release/8.0.4xx'
dotnet · Aug 8, 2024 · 3e4419f · 3e4419f
2 parents acec844 + fc472f2
commit 3e4419f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/DirectoryBasedTemplate.cs b/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/DirectoryBasedTemplate.cs
@@ -142,9 +142,14 @@ internal Task ValidateAsync(ValidationScope scope, CancellationToken cancellatio
         {
             string filename = locFile.Name;
             string localeStr = filename.Substring(LocalizationFilePrefix.Length, filename.Length - LocalizationFilePrefix.Length - LocalizationFileExtension.Length);
+            CultureInfo? locale = null;
 
-            CultureInfo? locale = CultureInfo.GetCultures(CultureTypes.AllCultures).FirstOrDefault(c => c.Name.Equals(localeStr, StringComparison.OrdinalIgnoreCase));
-            if (locale == null)
+            try
+            {
+                // PERF: Avoid calling CultureInfo.GetCultures and searching the results as it heavily allocates on each invocation.
+                locale = CultureInfo.GetCultureInfo(localeStr);
+            }
+            catch (CultureNotFoundException)
             {
                 Logger.LogWarning(LocalizableStrings.LocalizationModelDeserializer_Error_UnknownLocale, localeStr);
             }