Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate supporting baseline in dotnet new and template engine #4062

Open
vlada-shubina opened this issue Oct 25, 2021 · 5 comments
Open

Evaluate supporting baseline in dotnet new and template engine #4062

vlada-shubina opened this issue Oct 25, 2021 · 5 comments
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@vlada-shubina
Copy link
Member

vlada-shubina commented Oct 25, 2021

Currently template engine supports baseline: set of predefined input parameters that can be used when running or filtering templates.

dotnet new supports --baseline switch, but for now it is hidden.

Evaluate do we need this feature enabled for .NET 7, keep it hidden as is or should we remove it.

@vlada-shubina vlada-shubina added the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Oct 25, 2021
@baronfel
Copy link
Member

Some open questions for me to investigate:

  • Need to run down places where this feature is currently used - this should be easily doable from the search manifest
  • Some code/design archeology to run down the history/driving use case of the feature

@baronfel
Copy link
Member

Internal Usage:

  • dotnet/templating - used to set the Framework parameter in the class library templates
  • dotnet/aspnetcore - not used
  • dotnet/winforms - not used
  • dotnet/maui - not used

External Usage:

All of the external usage feels very copy/pasted from our templates to me. This isn't surprising, given that we don't have a template-for-templates. I don't think that this functionality is very widely used at the moment. There is a potential use case for it as a solution to #3654, however.

@vlada-shubina
Copy link
Member Author

vlada-shubina commented Dec 20, 2021

No change to this behavior in scope of #2191, the baseline option remains hidden.
Keeping the issue open for discussions.

@YuliiaKovalova YuliiaKovalova added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Jan 3, 2023
@baronfel
Copy link
Member

baronfel commented Jan 5, 2023

We should deprecate baseline - it's not widely used in the ecosystem and where it is used we have no evidence that template users actually use the baselines.

@baronfel baronfel removed the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Jan 5, 2023
@baronfel baronfel added this to the Backlog milestone Jan 5, 2023
@vlada-shubina
Copy link
Member Author

As it was agreed to deprecate baseline, we need to make all code that uses it obsolete. The action is purely refactoring, until obsolete code is agreed to be removed.

Consider removing --baseline option from CLI or make it obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

3 participants