Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.2xx] Update dependencies from dotnet/arcade #6894

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 28, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 13578d23-ac16-4bd6-de56-08daac421294
  • Build: 20230720.3
  • Date Produced: July 20, 2023 4:55:53 PM UTC
  • Commit: c9c125ccc43361cd94433c2d7f7069d465ad11a5
  • Branch: refs/heads/release/7.0

…720.3

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.23361.2 -> To Version 7.0.0-beta.23370.3
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner July 28, 2023 12:38
@v-wuzhai
Copy link
Member

@marcpopMSFT @MiYanni I have pushed a change to unblock the build. Could you help to review it?

@@ -59,12 +59,16 @@ public ValueWrapper(T val)

public T Val { get; private set; }

#pragma warning disable IDE0251 // Make member 'readonly'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try making Equals and GetHashCode readonly? Seems like that's what the error message itself suggests.

@v-wuzhai
Copy link
Member

v-wuzhai commented Aug 1, 2023

There are two reasons why I am doing this fix:

1: IDE0251: Member can be made 'readonly', Source: https://github.com/dotnet/docs/blob/main/docs/fundamentals/code-analysis/style-rules/ide0251.md?plain=1

2: To maintain the same processing as other branches. For example: https://github.com/dotnet/templating/blob/main/src/Microsoft.TemplateEngine.Utils/ListExtensions.cs#L62

But I still made the change, because it looks more concise. BTW, in order to maintain consistency, I want to confirm that do we need to make the same change to the other branches?

@marcpopMSFT
Copy link
Member

I just realized that this PR is for 7.0.2xx which is now out of support. I'll go ahead and close it and we can check if the 0251 change is needed in other branches when they fail.

@marcpopMSFT marcpopMSFT closed this Aug 1, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-release/7.0.2xx-158b6168-b7b5-4d7c-bb08-0f54709a542b branch August 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants