Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0.2xx] Update dependencies from dotnet/arcade #6894

Closed
wants to merge 4 commits into from
Closed

[release/7.0.2xx] Update dependencies from dotnet/arcade #6894

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de996ab
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Jul 28, 2023
6afa82a
Fix the code line that violate rule
v-wuzhai Jul 31, 2023
f487b57
Fix
v-wuzhai Jul 31, 2023
2cb6305
Set members to readonly
v-wuzhai Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.23361.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.23370.3">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>cae11bc40b691f546d788f7ab37f7eaf0e24ded8</Sha>
<Sha>c9c125ccc43361cd94433c2d7f7069d465ad11a5</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
</ToolsetDependencies>
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"dotnet": "7.0.109"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "7.0.0-beta.23361.2"
"Microsoft.DotNet.Arcade.Sdk": "7.0.0-beta.23370.3"
}
}
4 changes: 4 additions & 0 deletions src/Microsoft.TemplateEngine.Utils/ListExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,16 @@ public ValueWrapper(T val)

public T Val { get; private set; }

#pragma warning disable IDE0251 // Make member 'readonly'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try making Equals and GetHashCode readonly? Seems like that's what the error message itself suggests.

public override bool Equals(object obj)
#pragma warning restore IDE0251 // Make member 'readonly'
{
return obj is ValueWrapper<T> v && Equals(Val, v.Val);
}

#pragma warning disable IDE0251 // Make member 'readonly'
public override int GetHashCode()
#pragma warning restore IDE0251 // Make member 'readonly'
{
return Val?.GetHashCode() ?? 0;
}
Expand Down