feature/system-command-line --> main #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
force-pushed
the
feature/system-command-line
branch
from
803fb52
to
e72ce4c
Compare
vlada-shubina
commented
Dec 27, 2021
| } | ||
| } | ||
| } | ||
| //#nullable enable |
| string commandName) | ||
| : base(host, logger, callbacks, commandName, SymbolStrings.Command_AliasAdd_Description) { } | ||
|
|
||
| protected override Task<NewCommandStatus> ExecuteAsync(AliasAddCommandArgs args, IEngineEnvironmentSettings environmentSettings, InvocationContext context) => throw new NotImplementedException(); |
| this.Add(new AliasShowCommand(host, telemetryLogger, callbacks)); | ||
| } | ||
|
|
||
| protected override Task<NewCommandStatus> ExecuteAsync(AliasCommandArgs args, IEngineEnvironmentSettings environmentSettings, InvocationContext context) => throw new NotImplementedException(); |
| string commandName) | ||
| : base(host, logger, callbacks, commandName, SymbolStrings.Command_AliasShow_Description) { } | ||
|
|
||
| protected override Task<NewCommandStatus> ExecuteAsync(AliasShowCommandArgs args, IEngineEnvironmentSettings environmentSettings, InvocationContext context) => throw new NotImplementedException(); |
| { | ||
| //TODO: consider refactoring based on command definition |
| string? defaultLanguage) | ||
| { | ||
| IReadOnlyDictionary<string, string?>? appliedParameterMatches = TemplateCommandInput.GetTemplateParametersFromCommand(commandInput); | ||
| //TODO: implement it for template options matching |
| { | ||
| if (string.IsNullOrWhiteSpace(commandInput.SearchNameCriteria) && SupportedFilters.All(filter => !filter.IsFilterSet(commandInput)) && !commandInput.RemainingParameters.Any()) | ||
| if (string.IsNullOrWhiteSpace(commandArgs.SearchNameCriteria) && !commandArgs.AppliedFilters.Any()) | ||
| //TODO: implement it for template options matching |
| IEnumerable<string> appliedFilters = commandArgs.AppliedFilters | ||
| .Select(filter => $"{commandArgs.GetFilterToken(filter)}='{commandArgs.GetFilterValue(filter)}'"); | ||
|
|
||
| //TODO: implement it for template options matching |
| var builder = new CommandLineBuilder(command) | ||
| //.UseExceptionHandler(ExceptionHandler) | ||
| //.UseLocalizationResources(new CommandLineValidationMessages()) | ||
| //TODO: decide if it's needed to implement it; and implement if needed |
There was a problem hiding this comment.
#2191: implement [parse] and [suggest] directives
| //TODO: decide if it's needed to implement it; and implement if needed | ||
| //.UseParseDirective() | ||
| //.UseSuggestDirective() | ||
| .UseParseErrorReporting()//TODO: discuss with SDK if it is possible to use it. |
vlada-shubina
force-pushed
the
feature/system-command-line
branch
from
78b4c7d
to
1472467
Compare
DavidKarlas
approved these changes
Jan 27, 2022
vlada-shubina
changed the title
moved AsyncMutex to Utils, documented creating IEngineEnvironmentSettings in BaseCommand now
This allows ParseContext to be called while handing suggestions
Also fixed most --help problems.
exception handling is needed as System.CommandLine is getting long stack trace for the error
* fixed existing tests; added TestHost.GetVirtualHost helper method Added possibility to exclude test templates * install command parser tests; fixed install integration tests updated System.CommandLine to latest version tabular output refactoring (still needs parsing of --columns and --columns-all * fixed tab completion tests on unix/macos * help builder fix * implemented validation for incorrect order of options in non-legacy scenario
* fixes dotnet/templating #3807 update subcommand
Co-authored-by: Bekir Ozturk <60651445+bekir-ozturk@users.noreply.github.com>
…eplaced with creating InstantiateCommandArgs from NewCommandArgs
vlada-shubina
force-pushed
the
feature/system-command-line
branch
from
b49ff14
to
a8c5a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for merging system-command-line feature branch to main