[system-command-line] error handling for ambiguous results on template instantiation #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
changed the title
11 tasks
vlada-shubina
force-pushed
the
feature/system-command-line
branch
from
803fb52
to
e72ce4c
Compare
vlada-shubina
force-pushed
the
ambiguous-results
branch
from
693b819
to
b4219f8
Compare
bekir-ozturk
approved these changes
Dec 23, 2021
| reporter.WriteLine(LocalizableStrings.AmbiguousTemplatesMultiplePackagesHint.Bold().Red()); | ||
| if (templates.AllAreTheSame(t => t.MountPointUri)) | ||
| { | ||
| string templatePackage = Task.Run(() => GetTemplatePackage(templates.First())).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
We seem to be doing this somewhat often (.GetAwaiter().GetResult()). Maybe we can refactor some of this later to be async all the way.
There was a problem hiding this comment.
Main limitation for this is that help output is not async. Might be a good improvement to parser itself.
There was a problem hiding this comment.
I've made a note about this in related item in #2191
Co-authored-by: Bekir Ozturk <60651445+bekir-ozturk@users.noreply.github.com>
19 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#3809:
Solution
Ported implementation from old parser, no major differences from previous UX.
Only improvement: now in case of ambiguous template group hint for uninstalling the package is shown.
Checks:
#nullable enableto all the modified files ?