Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #2 #5532

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Improve docs #2 #5532

merged 3 commits into from
Nov 4, 2022

Conversation

JanKrivanek
Copy link
Member

Problem

As per #5016

Solution

  • Consolidated code samples formatting
  • Updated command samples syntax
  • removed irelevant/deprecated information

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@JanKrivanek JanKrivanek marked this pull request as ready for review November 2, 2022 08:41
@JanKrivanek JanKrivanek requested review from a team and baronfel as code owners November 2, 2022 08:41
@@ -3,6 +3,6 @@
- [Trying out "dotnet new" template updates and csproj with VS2017](https://www.hanselman.com/blog/TryingOutDotnetNewTemplateUpdatesAndCsprojWithVS2017.aspx) by @shanselman
- [Custom Project Templates Using dotnet new](http://rehansaeed.com/custom-project-templates-using-dotnet-new/) by @RehanSaeed
- [dotnet new Feature Selection](http://rehansaeed.com/dotnet-new-feature-selection/) by @RehanSaeed
- [Building a Solution with dotnet cli nuget templates](https://www.motowilliams.com/building-a-solution-with-dotnet-cli-nuget-templates) by @motowilliams
- [Building a Solution with dotnet cli nuget templates](https://motowilliams.com/2017-02-21-building-a-solution-with-dotnet-cli-nuget-templates/) by @motowilliams
- [Building And Debugging The dotnet new Templating Engine In Visual Studio](http://pioneercode.com/post/building-and-debugging-the-dot-net-new-templating-engine-in-visual-studio) by @chad-ramos
- [How To Create A dotnet new Project Template In .NET Core](http://pioneercode.com/post/how-to-create-a-dot-net-new-project-template-in-dot-net-core) - @chad-ramos
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pioneercode.com is currently unavailable as well. Trying to see if that's just a temporary outage or if we should remove those last two as well

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments/suggestions

docs/Runnable-Project-Templates.md Outdated Show resolved Hide resolved
docs/Runnable-Project-Templates.md Outdated Show resolved Hide resolved
docs/Runnable-Project-Templates.md Outdated Show resolved Hide resolved
docs/Testing-your-templates.md Outdated Show resolved Hide resolved
docs/template-resolution-for-dotnet-cli.md Outdated Show resolved Hide resolved
docs/template-resolution-for-dotnet-cli.md Show resolved Hide resolved
@JanKrivanek JanKrivanek merged commit 7dc89b3 into dotnet:main Nov 4, 2022
@JanKrivanek JanKrivanek deleted the doc-review-2 branch November 4, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants