Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NuGet.Configuration, NuGet.Credentials and NuGet.Protocol #7041

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Update NuGet.Configuration, NuGet.Credentials and NuGet.Protocol #7041

merged 5 commits into from
Sep 25, 2023

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Sep 12, 2023 •
edited
Loading

Fixes #6952 #6949 #6951

dependabot bot and others added 3 commits August 14, 2023 01:53
@dependabot
Bump NuGet.Configuration from 6.6.1 to 6.7.0 in /eng/dependabot
a608b23 
Bumps [NuGet.Configuration](https://github.com/NuGet/NuGet.Client) from 6.6.1 to 6.7.0.
- [Release notes](https://github.com/NuGet/NuGet.Client/releases)
- [Commits](https://github.com/NuGet/NuGet.Client/commits)

---
updated-dependencies:
- dependency-name: NuGet.Configuration
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@joeloff
Collapse NuGet updates to a single PR
aa392ba
@v-wuzhai
Fixed errors caused by nullable
f0031d8
@v-wuzhai v-wuzhai requested review from GangWang01 and a team as code owners September 12, 2023 10:35
@v-wuzhai
Copy link
Member Author

@dotnet/templating-engine-maintainers would you be able to review these changes?

@v-wuzhai
Copy link
Member Author

@mthalman @dotnet/templating-engine-maintainers Could you take a look at the SB errors here?

@mthalman
Copy link
Member

The packages listed in the error will need to be added to the SBRP repo. Instructions for that are here: https://github.com/dotnet/source-build-reference-packages#adding-new-packages. Once merged in that repo, it will cause a dependency flow to update the referenced SBRP in this repo. Merge that update in this PR and the error should go away.

@v-wuzhai v-wuzhai mentioned this pull request Sep 14, 2023
Merged
@v-wuzhai
Copy link
Member Author

@dotnet/templating-engine-maintainers @mthalman I'm not sure if we don't need updates for these packages?

@mthalman
Copy link
Member

It would seem this PR was accidentally closed, right? In your post for dotnet/source-build-reference-packages#783, it said "fix xxxx" which caused this PR to be closed when that one was merged.

@mthalman mthalman reopened this Sep 18, 2023
@v-wuzhai
Copy link
Member Author

/backport to release/8.0.1xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/templating/actions/runs/6256364096

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
@v-wuzhai v-wuzhai merged commit afffc77 into main Sep 25, 2023
11 checks passed
@v-wuzhai v-wuzhai deleted the v-wuzhai/Fixes#6952 branch September 25, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiYanni MiYanni MiYanni approved these changes

@GangWang01 GangWang01 Awaiting requested review from GangWang01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @mthalman @MiYanni @joeloff