Switch back to the shipped RC2 version. #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is dependency entirely.
joeloff
approved these changes
Oct 31, 2023
MiYanni
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
I saw you mentioned about the removal of the runtime dependency here: #7184 (comment)
I wasn't sure what that meant exactly. Looking at the commit you linked, it still isn't clear to me why the runtime dependency was added in the first place. Something VS related potentially?
|
I pinged in the CLI channel and Jan sent me an old thread talking about the runtime dependency and it affecting codeflow but I'm still not sure why it's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should explore removing this dependency entirely.
@MiYanni , the change to remove the runtime seems pretty simple so maybe we should just do that instead:
7e0fb4b