Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More move updates #2747

Merged
merged 4 commits into from
Feb 13, 2025
Merged

More move updates #2747

merged 4 commits into from
Feb 13, 2025

Conversation

MihaZupan
Copy link
Member

No description provided.

@MihaZupan MihaZupan added the Type: Infrastructure Infrastructure work that does not affect the actual shipping code label Feb 11, 2025
@MihaZupan MihaZupan added this to the YARP 2.3 milestone Feb 11, 2025
@MihaZupan
Copy link
Member Author

@WeihanLi Was the CLA reference / Code Of Conduct what you were referring to in #2738 (comment)? Or did I miss something else?

@WeihanLi
Copy link
Contributor

@WeihanLi Was the CLA reference / Code Of Conduct what you were referring to in #2738 (comment)? Or did I miss something else?

Looks good to me 👍

WeihanLi
WeihanLi approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@WeihanLi WeihanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan MihaZupan merged commit 1bb1741 into dotnet:main Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeihanLi WeihanLi WeihanLi approved these changes

@benjaminpetit benjaminpetit benjaminpetit approved these changes

Assignees
No one assigned
Labels
Type: Infrastructure Infrastructure work that does not affect the actual shipping code
Projects
None yet
Milestone
YARP 2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MihaZupan @WeihanLi @benjaminpetit