Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 为unitofwork/manager 增加async 功能 支持 core3.1及以上版本 #1220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luoyunchong
Copy link
Collaborator

No description provided.

@2881099
Copy link
Collaborator

2881099 commented Aug 22, 2022

暂时保留更改意见,比如 BeginAsync 那里在 AOP 动态代理处理起来会比较麻烦,最终还是转嫁到我们回答问题。

@hyzx86
Copy link
Contributor

hyzx86 commented Jun 23, 2024

暂时保留更改意见,比如 BeginAsync 那里在 AOP 动态代理处理起来会比较麻烦,最终还是转嫁到我们回答问题。

直接备注到XML 方法上 或者使用 特性标注增加提醒?

@@ -181,5 +176,95 @@ public void Dispose()
GC.SuppressFinalize(this);
}
}

#if NETCOREAPP3_1_OR_GREATER
public async Task<DbTransaction> GetOrBeginTransactionAsync(bool isCreate = true, CancellationToken cancellationToken = default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public async Task<DbTransaction> GetOrBeginTransactionAsync(bool isCreate = true, CancellationToken cancellationToken = default)
[Obsolete("实验功能,在 AOP 动态代理处理起来会比较麻烦,https://github.com/dotnetcore/FreeSql/pull/1220")]
public async Task<DbTransaction> GetOrBeginTransactionAsync(bool isCreate = true, CancellationToken cancellationToken = default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants