chore: update service worker font handling#1024
Open
macite wants to merge 1 commit intodoubtfire-lms:8.0.xfrom
Open
chore: update service worker font handling#1024macite wants to merge 1 commit intodoubtfire-lms:8.0.xfrom
macite wants to merge 1 commit intodoubtfire-lms:8.0.xfrom
Conversation
Attempt to address issue with DLI loading of fonts. This should allow the service working to load these now.
There was a problem hiding this comment.
Pull Request Overview
Updates the Angular service worker configuration to improve font loading for DLI installations by moving Google Fonts caching from external assets to a dedicated data group with proper caching strategy.
- Migrated Google Fonts from external assets to a dedicated cache group with specific configuration
- Applied proper caching strategy with freshness approach and 7-day max age for font resources
- Cleaned up JSON formatting for better readability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| { | ||
| "name": "google-fonts-cache", | ||
| "urls": ["https://fonts.gstatic.com/**"], |
There was a problem hiding this comment.
The URL pattern only covers fonts.gstatic.com but the removed external asset included fonts.googleapis.com. This change may break CSS font loading from Google Fonts API, as fonts.googleapis.com serves the CSS files that reference fonts.gstatic.com resources.
Suggested change
| "urls": ["https://fonts.gstatic.com/**"], | |
| "urls": ["https://fonts.googleapis.com/**", "https://fonts.gstatic.com/**"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address issue with DLI loading of fonts. This should allow the service working to load these now.
Currently the service worker fails to load these fonts on reload for the DLI installation. This should allow the client to access these as required.