refactor: migrate units index state from AngularJS to Angular#1067
Open
JeffySam wants to merge 6 commits intodoubtfire-lms:9.xfrom
Open
refactor: migrate units index state from AngularJS to Angular#1067JeffySam wants to merge 6 commits intodoubtfire-lms:9.xfrom
JeffySam wants to merge 6 commits intodoubtfire-lms:9.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs a strict migration of the Units Index state from AngularJS (CoffeeScript) to Angular.
The legacy AngularJS state and template have been fully removed and replaced with an Angular component and Angular-managed UI-Router state.
Changes
index.coffeeindex.tpl.htmlindex.component.tsindex.component.htmlindex.component.scssindex.state.tsdoubtfire.states.tsindex.ajs.module.ts) to preserve module dependency resolution (no logic, no state)Migration Notes
Testing
npm start/units/:unitId)