Skip to content

Commit

Permalink
Add test case
Browse files Browse the repository at this point in the history
Cannot use serverless.cli.log as it causes test case to fail
  • Loading branch information
developer-carsony authored and e129348 committed Jun 17, 2020
1 parent 2d66937 commit e791fbc
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
2 changes: 2 additions & 0 deletions __tests__/fixtures/lambda-layer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
require('/opt/lambdaLayer.js');
require('test-dep/file');
9 changes: 9 additions & 0 deletions __tests__/get-dependency-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,12 @@ test('understands local named dependencies', (t) => {
t.true(list.some(item => item.endsWith('dep-local-named.js')));
t.true(list.some(item => item.endsWith('local/named/index.js')));
});

test('skip dependencies like /opt/lambaLayer.js', (t) => {
const fileName = path.join(__dirname, 'fixtures', 'lambda-layer.js');

const list = getDependencyList(fileName, serverless);

t.true(list.some(item => item.indexOf(`/opt/lambdaLayer.js`) == -1));
t.true(list.some(item => item.match(/test-dep/)));
});
2 changes: 1 addition & 1 deletion get-dependency-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = function(filename, serverless) {
function handle(name, basedir, optionalDependencies, peerDependenciesMeta) {
const moduleName = requirePackageName(name.replace(/\\/, '/'));
if (moduleName === null) {
serverless.cli.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`);
console.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`);
return null;
}

Expand Down

0 comments on commit e791fbc

Please sign in to comment.