Return empty array when no data is found instead of a null value

dovereem · Sep 22, 2022 · 09705c4 · 09705c4
1 parent e0542d2
commit 09705c4
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/RdwApiClient/RdwApiClient.php b/src/RdwApiClient/RdwApiClient.php
@@ -52,11 +52,16 @@ protected function processApiResponse(Response $response): array
             throw new UnexpectedApiResponseException("API endpoint did not return valid JSON. Received: " . $response->getBody()->getContents());
         }
 
+        if (!is_array($results)) {
+            throw new UnexpectedApiResponseException("API endpoint did not return an expected JSON array. Received: " . $response->getBody()->getContents());
+        }
+
         return $results;
     }
 
 
-    public function getLicensedVehicleDataByLicensePlateNumber(string $licensePlateNumber): ?array {
+    public function getLicensedVehicleDataByLicensePlateNumber(string $licensePlateNumber): array
+    {
         $licensePlateNumber = $this->normalizeLicensePlateNumber($licensePlateNumber);
 
         $response = $this->createGuzzleClient()->get(
@@ -67,7 +72,7 @@ public function getLicensedVehicleDataByLicensePlateNumber(string $licensePlateN
         );
         $results = $this->processApiResponse($response);
 
-        return empty($results) ? null : $results[0];
+        return empty($results) ? [] : $results[0];
     }
 
 }