Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for NahimicOSD.dll #338

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Add check for NahimicOSD.dll #338

merged 1 commit into from
Jan 12, 2025

Conversation

dpaulat
Copy link
Owner

@dpaulat dpaulat commented Jan 10, 2025

If NahimicOSD.dll is detected, a dialog similar to the following will display (a different dll has been substituted in the screenshot):

image

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@dpaulat dpaulat force-pushed the hotfix/warn-on-nahimic-dll branch from 8a5b35a to a947dc6 Compare January 12, 2025 07:10
@dpaulat dpaulat merged commit d81f187 into develop Jan 12, 2025
4 of 5 checks passed
@dpaulat dpaulat deleted the hotfix/warn-on-nahimic-dll branch January 12, 2025 07:59
Copy link

@Leviathenn Leviathenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants