Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update vendored six from 1.11.0 to 1.16.0 #2398

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

shifqu
Copy link
Contributor

@shifqu shifqu commented Sep 28, 2023

In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.

closes #2282


This change is Reviewable

In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
@@ -643,13 +661,16 @@ def u(s):
import io
StringIO = io.StringIO
BytesIO = io.BytesIO
del io
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new del statement. Does the same condition here apply as in #979 (comment)?

@gpapia
Copy link

gpapia commented Oct 3, 2023

kafka-python 2.0.2 doesn't work anymore (a ModuleNotFoundError) with Python 3.12 (why?) without this PR. It should be great to merge it.

@pawel-swiecki-saucelabs
Copy link

pawel-swiecki-saucelabs commented Oct 11, 2023

@gpapia Yes, this MR will most likely resolve ModuleNotFoundError, see #2401.

@shifqu Do you know who can be pinged to review this?

@wbarnha
Copy link
Collaborator

wbarnha commented Oct 17, 2023

Thank you for the PR, sorry I didn't notice this sooner. I was hoping for a release of v2.0.3 before pulling in changes such as this. If the workflows pass, I'll approve.

@wbarnha wbarnha self-requested a review October 17, 2023 17:16
@wbarnha wbarnha added the dependencies Pull requests that update a dependency file label Oct 17, 2023
Copy link
Collaborator

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't fix the 3.12 tests entirely, but nevertheless a step in the right direction. The failing async test is a separate issue. Approved!

@AntonOfTheWoods
Copy link

@wbarnha , can this not get merged without the tests passing, even though the error is unrelated?

@StephenR-Softcom
Copy link

Thanks for the Pull Request, I am also waiting for the solution so kafka-python works with Python 3.12.0

@wbarnha
Copy link
Collaborator

wbarnha commented Nov 2, 2023

Sure, I'll make an exception to merge this.

@wbarnha wbarnha merged commit d894e9a into dpkp:master Nov 2, 2023
17 of 19 checks passed
@fcs-ts
Copy link

fcs-ts commented Nov 2, 2023

Any chance of getting a point release for this change soon?

@wbarnha
Copy link
Collaborator

wbarnha commented Nov 3, 2023

I'll reach out to Dana to see if I can get the ball rolling!

@Romain-Geissler-1A
Copy link

Hi,

Sorry for jumping on this closed thread, I found it after hitting a similar import issue with six after upgrading to python 3.12 ;) Are there still currently some blocking points preventing to use this package on python 3.10 to 3.12 ? I see that the six package was just one issue, but they might be others (at least for python 3.12).

@wbarnha
Copy link
Collaborator

wbarnha commented Nov 6, 2023

Hi,

Sorry for jumping on this closed thread, I found it after hitting a similar import issue with six after upgrading to python 3.12 ;) Are there still currently some blocking points preventing to use this package on python 3.10 to 3.12 ? I see that the six package was just one issue, but they might be others (at least for python 3.12).

Not that I know of. Since all tests are now passing for 3.12, I don't see any immediate reason why this wouldn't work. But I should note I personally have not used this on 3.12.

@StephenR-Softcom
Copy link

Hi,

Sorry for jumping on this closed thread, I found it after hitting a similar import issue with six after upgrading to python 3.12 ;) Are there still currently some blocking points preventing to use this package on python 3.10 to 3.12 ? I see that the six package was just one issue, but they might be others (at least for python 3.12).

I have successfully used the library with Python 3.11 on Windows in the last release available from pip.

@Romain-Geissler-1A
Copy link

Ok, so I will wait for a release to be cut and published through PyPi then. Thanks for your work ;)

@wbarnha
Copy link
Collaborator

wbarnha commented Nov 7, 2023

I apologize for taking so with long with this release. I'm still waiting to hear back from the maintainer. You can directly install from this repository via pip install git+https://github.com/dpkp/kafka-python.git, however I do not recommend making this a normal trend.

@aisven
Copy link

aisven commented Feb 21, 2024

@wbarnha Just arrived here after a short journey that took me via https://blog.pecar.me/six-warnings

Could you given an update as to when a release surpassing the current 2020 version 2.0.2 of kafka-python can be expected?

@wbarnha
Copy link
Collaborator

wbarnha commented Feb 21, 2024

Hi there, I'm waiting for PyPi credentials. Until then, I am powerless. We have been trying to get in contact with the author, but he has been unresponsive again. ☹️

@aisven
Copy link

aisven commented Feb 21, 2024

@wbarnha Thank you for your reply. Glad to hear you keep trying!

@wbarnha
Copy link
Collaborator

wbarnha commented Mar 4, 2024

Still trying. Thanks for your patience. 🥲

@skywrathmage006
Copy link

Hi there,
May I know when the release for kafka-python be available for Python 3.11 / 3.12?
Or are there any alternative packages that are equivalent for Python 3.11 / 3.12?

@wbarnha
Copy link
Collaborator

wbarnha commented Apr 8, 2024

Hi there, May I know when the release for kafka-python be available for Python 3.11 / 3.12? Or are there any alternative packages that are equivalent for Python 3.11 / 3.12?

See https://github.com/wbarnha/kafka-python-ng

jjaakola-aiven pushed a commit to aiven/kafka-python that referenced this pull request May 13, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
keejon added a commit to aiven/kafka-python that referenced this pull request May 13, 2024
…to-1.16.0

build: update vendored six from 1.11.0 to 1.16.0 (dpkp#2398)
jjaakola-aiven pushed a commit to aiven/kafka-python that referenced this pull request May 13, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
bradenneal1 pushed a commit to bradenneal1/kafka-python that referenced this pull request May 16, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
@jaredmauch
Copy link

I would also like to 👍 releasing this as I just saw this today in a clean install of ubuntu noble and would prefer to not switch to the other package if this one can be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python 3.12.0] ModuleNotFoundError: No module named 'kafka.vendor.six.moves' ImportWarning on Python 3.10