Implement option to generate alternative typescript format #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpup
force-pushed
the
dan/new-format
branch
2 times, most recently
from
a132d46 to
f55a1f7
Compare
seanami
reviewed
May 21, 2024
| When `use_static_classes` is set to false, you can implement your code will look like this: | ||
|
|
||
| ```ts | ||
| import { increase } from "./counter.pb"; |
There was a problem hiding this comment.
You could add a third example here suggesting a way to get an equivalent to the old format, if desired:
import { * as CounterService } from "./counter.pb";(I think this works, right?)
There was a problem hiding this comment.
That should work, I think you'd also get CounterService.CounterServiceClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @seanami,
This turned out to be a pretty big change.
The primary change is to introduce a
use_static_classesflag which switchesthe output format. With the flag set to false, instead of using a static class
a function is generated along with a stateful Client class. See #23
To support this change I had to rework how integration tests work. Within
/test/integrationthere are now sub-folders that represent differentconfigurations of the generator or gRPC gateway. I've also removed Karma — which
was deprecated — and switched to Web Test Runner, which looks a lot simpler.
I've also got rid of the
/scripts/directory and consolidated all the commandswithin the
Makefile.I've also made it so none of the generated files for the integration tests are checked
into source control.
Please review the following commits I made in branch dan/new-format:
71ec29f (2024-05-20 16:11:32 -0700)
Implement option to generate alternative typescript format
Code review reminders, by giving a LGTM you attest that: