Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where a message has multiple oneof fields #31

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

dpup
Copy link
Owner

@dpup dpup commented Jul 23, 2024

Hello @,

Please review the following commits I made in branch dan/oneoffix:

cdf8475 (2024-07-23 15:10:38 -0700)
Fix issue where a message has multiple oneof fields

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@dpup dpup merged commit 131dbd5 into main Jul 23, 2024
2 checks passed
@dpup dpup deleted the dan/oneoffix branch July 23, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant