-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 10.2 and Swift 5. #4
Conversation
lm2343635
commented
Mar 27, 2019
•
edited
Loading
edited
- Fix the build warning after Xcode 10.2.
- Update to Swift 5.
This warning happens on Xcode 10.2 |
Hi @dqhieu |
@lm2343635 Are you getting the following error? It doesn't look like this section got updated in your PR. |
Hi, @fishcharlie |
@lm2343635 Nope. Not on master. On the latest CocoaPods version. |
@fishcharlie |
Hi, sorry guys I was very busy last week. I will try to merge and update the CocoaPods version this week. Thank you guys very much for helping me keep this library up to date 👍 |
@dqhieu Any updates on this? |
I'm working on it now |
Updated guys. Thanks for your help. I am very appreciated. 🙇🏻♂️ |
Why do you updated your minimum deployment target to 11.0? |
I mean the minimum deployment target in the podspec file.
|
@lm2343635 I will revert this change, sorry for that |
Done @lm2343635 , please use version 1.3.1. Thanks 🙇 |
Thanks! @dqhieu |
Hi guys, if you need any improvement or feature request feel free to comment in this issue: #7 |