fix(90kernel-modules): add intel_lpss_pci for MacBook Pro 2017 #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI: ``` $ dmesg input: Apple SPI Keyboard as /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-APP000D:00/input/input4 ``` The SPI controller requires the `intel_lpss_pci` kernel module: ``` $ lspci -vv 00:1e.3 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO SPI Controller dracutdevs#1 (rev 21) Subsystem: Intel Corporation Sunrise Point-LP Serial IO SPI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin D routed to IRQ 23 Region 0: Memory at 9282c000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] Vendor Specific Information: Len=14 <?> Kernel driver in use: intel-lpss Kernel modules: intel_lpss_pci ``` Fedora builds `intel_lpss_pci` into the kernel: ``` $ grep INTEL_LPSS_PCI /lib/modules/6.5.11-300.fc39.x86_64/config CONFIG_MFD_INTEL_LPSS_PCI=y ``` But Ubuntu builds `intel_lpss_pci` only as module: ``` $ grep INTEL_LPSS_PCI /boot/config-6.5.0-10-generic CONFIG_MFD_INTEL_LPSS_PCI=m ``` So explicitly include `intel_lpss_pci` to support the keyboard. Bug-Ubuntu: https://launchpad.net/bugs/2042710 fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards") Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
github-actions
bot
added
modules
LaszloGombos
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI:
The SPI controller requires the
intel_lpss_pcikernel module:Fedora builds
intel_lpss_pciinto the kernel:But Ubuntu builds
intel_lpss_pcionly as module:So explicitly include
intel_lpss_pcito support the keyboard.Bug-Ubuntu: https://launchpad.net/bugs/2042710
fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards")
This pull request changes...
Changes
Checklist