Avoid double-encoding query #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Hash#to_query already URL-encodes the values, causing reserved characters and non-ASCII characters to be double-encoded and the query to not return any results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Queries that use non-URL-safe characters currently get double-encoded, causing MediaWiki not to return any matching results.
Other Information
Hash#to_queryalready URL-encodes the values. CallingCGI::escapeon top of that causes reserved characters and non-ASCII characters to be double-encoded.E.g.
I suspected this was the case in #17 (comment), but I didn't investigate it properly until now.
Copyright assignment
I agree to the Contributor's Agreement and assign all rights, including copyright, to these Contributions to Security Roots.