feat(Openshift): Openshift CRD Flag to Ignore fsGroup #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2024
Pothulapati
reviewed
Mar 11, 2024
internal/resources/resources.go
Outdated
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| // Openshift requires IDs to not be set, as it injects a fixed randomized ID per namespace into all pods. |
There was a problem hiding this comment.
This is a valid fix, but i'm not yet sure if writing to a FS works with this. Can you try running SAVE command on the DF instance and tell me what it says?
Thanks
There was a problem hiding this comment.
I'm not sure the correct way to run that, but I did enable snapshotting since that also writes to disk.
ArthurVardevanyan/HomeLab@7a5ff45
I20240311 12:20:00.002751 8 save_stages_controller.cc:321] Saving "/dragonfly/snapshots/dump-2024-03-11T12:20:00-summary.dfs" finished after 0 us
There was a problem hiding this comment.
That does seem to work!
Pothulapati
reviewed
Mar 11, 2024
api/v1alpha1/dragonfly_types.go
Outdated
| // (Optional) Whether running on Openshift or not | ||
| // +optional | ||
| // +kubebuilder:validation:Optional | ||
| Openshift bool `json:"openshift,omitempty"` |
There was a problem hiding this comment.
Maybe can you rename this to skipFSGroup? which makes better sense than Openshift? LGTM otherwise! 👍🏼
There was a problem hiding this comment.
Updated:
ArthurVardevanyan/HomeLab@ce549e5
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
ArthurVardevanyan
force-pushed
the
openshift-support
branch
from
0153a59 to
ded5188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue for details: #116
This is my current workaround: https://github.com/ArthurVardevanyan/HomeLab/blob/main/kubernetes/dragonfly-operator/base/kyverno.yaml
Deployed PR: ArthurVardevanyan/HomeLab#63