feat(service): added support for labels on serviceSpec

[thecodeassassin]

Tailscale services require labels to assign a ProxyClass.

This PR adds support for labels on serviceSpec to accomplish this goal.

[Abhra303]

Thanks for the PR! Mostly looks good. See some comments.

[thecodeassassin]

@Abhra303 Should be good now, changes in manifests reverted

[Abhra303]

Could you please sign the commits so that I can merge?

[thecodeassassin]

Could you please sign the commits so that I can merge?

I am sorry, i don't know what you mean.

[Abhra303]

To merge your PRs, you need to sign your commits meaning you agree with our licensing terms and conditions. See https://github.com/dragonflydb/dragonfly/blob/main/CONTRIBUTING.md#signoff-commits.

You can rebase all the commits into a single commit and sign it with -s flag or edit each commit and sign.
Example to signoff last four commits:

git rebase --signoff HEAD~4

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[thecodeassassin]

I think that should be done ? Can you please check? never signed commits before.

[Abhra303]

Looks like you didn't remove the old commits that are not signed, can you please remove those?

Also you should use your full name to sign ( I see only Stephen here). You can set your full name by git config user.name "Your FullName". Then sign the commits again. Additionally you can also set PGP key to sign commits (See https://codex.so/gpg-verification-github). Signing with PGP keys verify that its really you and not an imposter signing on behalf of you. Its preferred to have the PGP key.

never signed commits before.

No issuse, take your time. Its really important to sign your commits (most of the open source repos require signed commits). Once you set up this, its very easy to sign commits (just add a -S flag while committing changes). Don't hesitate to ask me if you are stuck anywhere (e.g. PGP setup/ signing, removing the old unsigned commits etc.).

[thecodeassassin]

@

Looks like you didn't remove the old commits that are not signed, can you please remove those?

Also you should use your full name to sign ( I see only Stephen here). You can set your full name by git config user.name "Your FullName". Then sign the commits again. Additionally you can also set PGP key to sign commits (See https://codex.so/gpg-verification-github). Signing with PGP keys verify that its really you and not an imposter signing on behalf of you. Its preferred to have the PGP key.

never signed commits before.

No issuse, take your time. Its really important to sign your commits (most of the open source repos require signed commits). Once you set up this, its very easy to sign commits (just add a -S flag while committing changes). Don't hesitate to ask me if you are stuck anywhere (e.g. PGP setup/ signing, removing the old unsigned commits etc.).

Allright, should be good now

[Abhra303]

Thanks! It will work!