-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): add support for nodePort #205
Conversation
I tried to follow the steps from CONTRIBUTING.md and deployt this version of the operator, but the CRDs didn't change. When I try to apply the following file, I get the error apiVersion: dragonflydb.io/v1alpha1
kind: Dragonfly
metadata:
labels:
app.kubernetes.io/name: dragonfly
app.kubernetes.io/instance: dragonfly-sample
app.kubernetes.io/part-of: dragonfly-operator
app.kubernetes.io/managed-by: kustomize
app.kubernetes.io/created-by: dragonfly-operator
name: dragonfly-sample
spec:
replicas: 2
resources:
requests:
cpu: 500m
memory: 500Mi
limits:
cpu: 600m
memory: 750Mi
serviceSpec:
type: NodePort
nodePort: 20001 Did I miss any file that needs to be updated as well? I looked at the PR #187 for this change. |
@mueller-ma, you have put |
Closes dragonflydb#204 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Thanks for that hint. With a valid yaml Dragonfly manifest, I was able to deploy a dragonfly instance, that uses a fixed node port. |
…patch) (#786) This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.dragonflydb.io/dragonflydb/operator | patch | `v1.1.4` -> `v1.1.5` | | [dragonflydb/dragonfly-operator](https://togithub.com/dragonflydb/dragonfly-operator) | patch | `v1.1.4` -> `v1.1.5` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly-operator (dragonflydb/dragonfly-operator)</summary> ### [`v1.1.5`](https://togithub.com/dragonflydb/dragonfly-operator/releases/tag/v1.1.5) [Compare Source](https://togithub.com/dragonflydb/dragonfly-operator/compare/v1.1.4...v1.1.5) Release v1.1.5 Docker image: `docker.dragonflydb.io/dragonflydb/operator:v1.1.5` This release adds `nodePort` field to customize service node port and updates dragonfly version to `v1.20.1` ##### What's Changed - feat(service): add support for nodePort by [@​mueller-ma](https://togithub.com/mueller-ma) in [https://github.com/dragonflydb/dragonfly-operator/pull/205](https://togithub.com/dragonflydb/dragonfly-operator/pull/205) - fix(helm-release): Added back Helm Chart release CI job by [@​Aym3nTN](https://togithub.com/Aym3nTN) in [https://github.com/dragonflydb/dragonfly-operator/pull/209](https://togithub.com/dragonflydb/dragonfly-operator/pull/209) - feat: Upgrade k8s versions by [@​sergeyshevch](https://togithub.com/sergeyshevch) in [https://github.com/dragonflydb/dragonfly-operator/pull/210](https://togithub.com/dragonflydb/dragonfly-operator/pull/210) - feat(helm): Add ServiceMonitor resource by [@​nlamirault](https://togithub.com/nlamirault) in [https://github.com/dragonflydb/dragonfly-operator/pull/212](https://togithub.com/dragonflydb/dragonfly-operator/pull/212) - fix(dashboard): Use correct metric to determine master by [@​cmergenthaler](https://togithub.com/cmergenthaler) in [https://github.com/dragonflydb/dragonfly-operator/pull/214](https://togithub.com/dragonflydb/dragonfly-operator/pull/214) - chore(dragonfly): bump version to v1.20.1 by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/215](https://togithub.com/dragonflydb/dragonfly-operator/pull/215) - feat(version): release 1.1.5 of Operator by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/216](https://togithub.com/dragonflydb/dragonfly-operator/pull/216) - fix(ci): remove chart version update step by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/217](https://togithub.com/dragonflydb/dragonfly-operator/pull/217) ##### New Contributors - [@​mueller-ma](https://togithub.com/mueller-ma) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/205](https://togithub.com/dragonflydb/dragonfly-operator/pull/205) - [@​Aym3nTN](https://togithub.com/Aym3nTN) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/209](https://togithub.com/dragonflydb/dragonfly-operator/pull/209) - [@​sergeyshevch](https://togithub.com/sergeyshevch) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/210](https://togithub.com/dragonflydb/dragonfly-operator/pull/210) - [@​nlamirault](https://togithub.com/nlamirault) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/212](https://togithub.com/dragonflydb/dragonfly-operator/pull/212) - [@​cmergenthaler](https://togithub.com/cmergenthaler) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/214](https://togithub.com/dragonflydb/dragonfly-operator/pull/214) **Full Changelog**: dragonflydb/dragonfly-operator@v1.1.4...v1.1.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
…5 ) (patch) (#5046) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [dragonflydb/dragonfly-operator](https://togithub.com/dragonflydb/dragonfly-operator) | patch | `v1.1.4` -> `v1.1.5` | | ghcr.io/dragonflydb/operator | patch | `v1.1.4` -> `v1.1.5` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly-operator (dragonflydb/dragonfly-operator)</summary> ### [`v1.1.5`](https://togithub.com/dragonflydb/dragonfly-operator/releases/tag/v1.1.5) [Compare Source](https://togithub.com/dragonflydb/dragonfly-operator/compare/v1.1.4...v1.1.5) Release v1.1.5 Docker image: `docker.dragonflydb.io/dragonflydb/operator:v1.1.5` This release adds `nodePort` field to customize service node port and updates dragonfly version to `v1.20.1` ##### What's Changed - feat(service): add support for nodePort by [@​mueller-ma](https://togithub.com/mueller-ma) in [https://github.com/dragonflydb/dragonfly-operator/pull/205](https://togithub.com/dragonflydb/dragonfly-operator/pull/205) - fix(helm-release): Added back Helm Chart release CI job by [@​Aym3nTN](https://togithub.com/Aym3nTN) in [https://github.com/dragonflydb/dragonfly-operator/pull/209](https://togithub.com/dragonflydb/dragonfly-operator/pull/209) - feat: Upgrade k8s versions by [@​sergeyshevch](https://togithub.com/sergeyshevch) in [https://github.com/dragonflydb/dragonfly-operator/pull/210](https://togithub.com/dragonflydb/dragonfly-operator/pull/210) - feat(helm): Add ServiceMonitor resource by [@​nlamirault](https://togithub.com/nlamirault) in [https://github.com/dragonflydb/dragonfly-operator/pull/212](https://togithub.com/dragonflydb/dragonfly-operator/pull/212) - fix(dashboard): Use correct metric to determine master by [@​cmergenthaler](https://togithub.com/cmergenthaler) in [https://github.com/dragonflydb/dragonfly-operator/pull/214](https://togithub.com/dragonflydb/dragonfly-operator/pull/214) - chore(dragonfly): bump version to v1.20.1 by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/215](https://togithub.com/dragonflydb/dragonfly-operator/pull/215) - feat(version): release 1.1.5 of Operator by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/216](https://togithub.com/dragonflydb/dragonfly-operator/pull/216) - fix(ci): remove chart version update step by [@​Abhra303](https://togithub.com/Abhra303) in [https://github.com/dragonflydb/dragonfly-operator/pull/217](https://togithub.com/dragonflydb/dragonfly-operator/pull/217) ##### New Contributors - [@​mueller-ma](https://togithub.com/mueller-ma) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/205](https://togithub.com/dragonflydb/dragonfly-operator/pull/205) - [@​Aym3nTN](https://togithub.com/Aym3nTN) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/209](https://togithub.com/dragonflydb/dragonfly-operator/pull/209) - [@​sergeyshevch](https://togithub.com/sergeyshevch) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/210](https://togithub.com/dragonflydb/dragonfly-operator/pull/210) - [@​nlamirault](https://togithub.com/nlamirault) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/212](https://togithub.com/dragonflydb/dragonfly-operator/pull/212) - [@​cmergenthaler](https://togithub.com/cmergenthaler) made their first contribution in [https://github.com/dragonflydb/dragonfly-operator/pull/214](https://togithub.com/dragonflydb/dragonfly-operator/pull/214) **Full Changelog**: dragonflydb/dragonfly-operator@v1.1.4...v1.1.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Closes #204