Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: minor clean ups before introducing ProvidedBuffers (#4… #4719

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

adiholden
Copy link
Collaborator

…709)"

This reverts commit a39d777.

This commit fails our regression test test_s3_snapshot
I am reverting it now untill the issue will be fixed

see regression pass on this branch - https://github.com/dragonflydb/dragonfly/actions/runs/13700629206

@adiholden adiholden requested a review from romange March 6, 2025 14:58
romange
romange previously approved these changes Mar 6, 2025
@romange
Copy link
Collaborator

romange commented Mar 6, 2025

you should exclude .vscode/c_cpp_properties.json from this PR

@adiholden
Copy link
Collaborator Author

you should exclude .vscode/c_cpp_properties.json from this PR

I am getting this error when trying to unrevert this changes
An error has occurred: InvalidConfigError:
==> File .pre-commit-config.yaml
==> At Config()
==> At key: default_stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /home/adi/.cache/pre-commit/pre-commit.log

Signed-off-by: adi_holden <adi@dragonflydb.io>
@adiholden adiholden enabled auto-merge (squash) March 6, 2025 16:00
@adiholden adiholden merged commit 14c7e29 into main Mar 6, 2025
10 checks passed
@adiholden adiholden deleted the test_stack_margin branch March 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants