Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: memory_reclaim_for_tiered_storage #4722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

C-mmon
Copy link

@C-mmon C-mmon commented Mar 6, 2025

When memory is low, actively attempt to reclaim memory. calculate how much memory is needed based on the memory low limit and memory budget.

two attempt phase.
1st phase, entire needed memory
2nd phase, with the remaining gap.

When memory is low, actively attempt to reclaim memory. 
calculate how much memory is needed based on the memory low limit and memory budget.

two attempt phase.
1st phase, entire needed memory
2nd phase,  with the remaining gap.


Signed-off-by: Aniket Kumar <aniketsinha101@gmail.com>
@romange
Copy link
Collaborator

romange commented Mar 7, 2025

Hello @C-mmon . A nice suggestion. Have you stumbled upon this case? Do you have a scenario that triggers this path?

@C-mmon
Copy link
Author

C-mmon commented Mar 7, 2025

Hey @romange ,
I have not stumbled upon this. I currently want to contribute to dragonfly db, and going through all todo comments.
I can try writing some test case, where I can trigger this path but may require some help or suggestion.

@romange
Copy link
Collaborator

romange commented Mar 7, 2025

Yes, usually we add tests, writing tests is tricky, especially with tiering.
with tests we can debate what needs to be done and how.

@C-mmon
Copy link
Author

C-mmon commented Mar 7, 2025

Sure, I will work on the test and update the pull request.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants