fix(transaction): Fix auto journaling in transaction #4737
Merged
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_enabled_auto_journal_
in the transaction. For example, if we are in multi-mode and one of the commands callsReviveAutoJournal
, the next commands withCO::NO_AUTOJOURNAL
will still be auto-journaled because we didn't setre_enabled_auto_journal_
to falsestreamId
is generated using Unix time, which can differ between the master and the replica, potentially causing replication issues. To fix this, we need to passtime_now_ms
from the master to the replica. To achieve this, theTIMENOW
option was added to theXADD
command.