fix test: test_replication_all increase key num #4747
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
kostasrim
approved these changes
Mar 11, 2025
| @@ -50,7 +50,7 @@ async def wait_for_replicas_state(*clients, state="online", node_role="slave", t | |||
| # Quick general test that replication is working | |||
| (1, 3 * [1], dict(key_target=1_000), 500), | |||
| # A lot of huge values | |||
| (2, 2 * [1], dict(key_target=1_000, huge_value_target=30), 500), | |||
| (2, 2 * [1], dict(key_target=5_000, huge_value_target=30), 500), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4534
The problem:
the test failed on check
assert compressed_blobs > 0
Because the number of keys is not very big and having lots of big values that disable compression on specific bucket, the chances that no bucket will be compressed increase
The fix:
increase number of keys in test