[wip] chore: asynchronous IO for connection fiber #6069
+297
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Nov 28, 2025
| } | ||
|
|
||
| phase_ = PROCESS; | ||
| bool is_iobuf_full = io_buf_.AppendLen() == 0; |
Contributor
Author
There was a problem hiding this comment.
No functional change from here and onwards in comparison IoLoop
kostasrim
commented
Nov 28, 2025
| await check_stats() | ||
|
|
||
|
|
||
| @pytest.mark.tls |
Contributor
Author
There was a problem hiding this comment.
no changes to the tests. I added the tls label to disable tls tests on the manual workflow I introduced (because tls is broken for now).
Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>
Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>
Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>
Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
IoLoopV2that removes fiber blocking read calls from the flow. This allows the connection fiber to handle other events while recv calls are handled asynchronously from readiness events triggered by a registered multishot poll.Follow up on a separate PR:
Resolves #6028