feat(storage): enhance RocksDB sync and compression options #1492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces improvements to logging and optimizes the RocksDB storage engine configuration. The most significant changes are the addition of debug logs after write operations and adjustments to RocksDB compression and sync settings to improve performance and observability.
Logging Improvements:
content_linux.rsandcontent_macos.rsto indicate completion of write operations. [1] [2]server/tcp.rsafter flushing the TCP writer to signal stream completion.RocksDB Storage Engine Optimization:
DEFAULT_BYTES_PER_SYNCand set RocksDB sync options (set_use_fsync(false)andset_bytes_per_sync) to optimize disk writes. [1] [2]ZstdtoLz4for consistency with the main compression type.WriteOptionswithsyncexplicitly set tofalse, potentially improving write performance.Related Issue
Motivation and Context
Screenshots (if appropriate)